Bug Fixes - July 7

[mpowell]

Here's the latest batch of bug fixes, released today! Please let us know if they're still not working as expected!

Favorites and least favorites not working on profile
Exactly as the title says, viewing the top and bottom ratings on your own profile, or that of another user, wasn't working properly. Now it is!

0.000 TCIs being generated
There was a mistake that was leading some users to have Top TCIs of "0.0000". These were obviously invalid, and the mistake in the code that was creating them has been found and patched up.

Title type missing on mobile
For whatever reason, we were just not showing this information box on mobile. Like, whether it's a TV Series, TV Mini-Series, Short Film, etc

Open Pagination Links in New Tab
We had been using buttons instead of anchors when displaying pagination links. This prevented some things that browsers do by default for links -- such as right-click to open in a new tab, or "copy link address".

Recommendation by date error
Silly error where we were considering films from 2010 and beyond, for the category "2020 and beyond".

[Ramy]

1. Not sure if it's a bug, but it's the second time I've noticed it:

On some movie pages, the director will be duplicated. Example: https://www.criticker.com/film/Ghostlight-2024/

The director of this movie (Kelly O'Sullivan) appears thrice on this page, leading to 3 different Kelly O'Sullivan pages:

https://www.criticker.com/people/Kelly-OSullivan/
https://www.criticker.com/people/Kelly-OSullivan-c/
https://www.criticker.com/people/Kelly-OSullivan-d/

Seems like multiple pages are being created for the same person? I've seen that happen for another movie too.

2. Blocked users are contributing to a film's avg percentile.
Example: For Ghostlight (2024), it says "Avg Percentile 82.66% from 6 total ratings", even though only 2 unblocked users have rated the film for me.

3. On rated movie pages, our own rating appears under Ratings & Reviews, among everyone else's. Seems unnecessary.

4. Just now after I submitted this comment, there were a bunch of error messages on top of the page:

[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 22: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 24: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 26: Attempt to read property "user_level" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 36: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 42: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 22: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 24: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 26: Attempt to read property "user_level" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 36: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file /home/critic/public_html/include/tier_gen.php on line 42: Attempt to read property "id" on int
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4328: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3059)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4328: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3059)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4328: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3059)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4328: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3059)

[td888]

I get these error messages on top of the page too.

[mpowell]

Thanks for reporting these problems.

I think we've got the PHP warnings on the Forum fixed up. As for the other ones...

On some movie pages, the director will be duplicated.

We'll take a look into this, and update here once we've found the reason!

2. Blocked users are contributing to a film's avg percentile.

We can also look at this one. Thanks for reporting it!

3. On rated movie pages, our own rating appears under Ratings & Reviews, among everyone else's. Seems unnecessary.

We're aware of this, and have a bug open on it

[mpowell]

2. Blocked users are contributing to a film's avg percentile.
Example: For Ghostlight (2024), it says "Avg Percentile 82.66% from 6 total ratings", even though only 2 unblocked users have rated the film for me.

This issue should now be fixed! Details can be found here. Thanks again for letting us know about this!